dqn
/
FBX2glTF
mirror of https://github.com/facebookincubator/FBX2glTF.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix fov computation from fbxsdk (#133) 

* fix fov computation from fbxsdk
This commit is contained in:
Michael Ranieri 2018-10-22 18:32:20 -07:00 committed by Pär Winzell
parent efd404764d
commit d38ccd935f
1 changed files with 52 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/fbx/Fbx2Raw.cpp
View File

@ -367,13 +367,64 @@ static void ReadMesh(RawModel &raw, FbxScene *pScene, FbxNode *pNode, const std:
}
}
//ar : aspectY / aspectX
double HFOV2VFOV(double h, double ar)
{
return 2.0 * std::atan((ar) * std::tan((h * FBXSDK_PI_DIV_180) * 0.5)) * FBXSDK_180_DIV_PI;
};
//ar : aspectX / aspectY
double VFOV2HFOV(double v, double ar)
{
return 2.0 * std::atan((ar) * std::tan((v * FBXSDK_PI_DIV_180) * 0.5)) * FBXSDK_180_DIV_PI;
}
// Largely adopted from fbx example
static void ReadCamera(RawModel &raw, FbxScene *pScene, FbxNode *pNode)
{
const FbxCamera *pCamera = pNode->GetCamera();
double filmHeight = pCamera->GetApertureHeight();
double filmWidth = pCamera->GetApertureWidth() * pCamera->GetSqueezeRatio();
// note Height : Width
double apertureRatio = filmHeight / filmWidth;
double fovx = 0.0f;
double fovy = 0.0f;
switch(pCamera->GetApertureMode())
{
case FbxCamera::EApertureMode::eHorizAndVert: {
fovx = pCamera->FieldOfViewX;
fovy = pCamera->FieldOfViewY;
break;
}
case FbxCamera::EApertureMode::eHorizontal: {
fovx = pCamera->FieldOfViewX;
fovy = HFOV2VFOV(fovx, apertureRatio);
break;
}
case FbxCamera::EApertureMode::eVertical: {
fovy = pCamera->FieldOfViewY;
fovx = VFOV2HFOV(fovy, 1.0 / apertureRatio);
break;
}
case FbxCamera::EApertureMode::eFocalLength: {
fovx = pCamera->ComputeFieldOfView(pCamera->FocalLength);
fovy = HFOV2VFOV(fovx, apertureRatio);
break;
}
default: {
fmt::printf("Warning:: Unsupported ApertureMode. Setting FOV to 0.\n");
break;
}
}
if (pCamera->ProjectionType.Get() == FbxCamera::EProjectionType::ePerspective) {
raw.AddCameraPerspective(
"", pNode->GetUniqueID(), (float) pCamera->FilmAspectRatio,
(float) pCamera->FieldOfViewX, (float) pCamera->FieldOfViewX,
(float) fovx, (float) fovy,
(float) pCamera->NearPlane, (float) pCamera->FarPlane);
} else {
raw.AddCameraOrthographic(