From 2efc17cbd5dc29cf13eb855302a9c1fbb28d008d Mon Sep 17 00:00:00 2001 From: Par Winzell Date: Fri, 25 Jan 2019 15:44:39 -0800 Subject: [PATCH] Don't export lights until the validator understands it. --- npm/tests/test/fbx2gltf.ts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/npm/tests/test/fbx2gltf.ts b/npm/tests/test/fbx2gltf.ts index 73ec0c7..76748a6 100644 --- a/npm/tests/test/fbx2gltf.ts +++ b/npm/tests/test/fbx2gltf.ts @@ -8,6 +8,7 @@ import { validateBytes } from 'gltf-validator'; interface Model { path: string; ignoredIssues?: Array; + args?: Array; } const MODELS :Array = [ @@ -21,8 +22,14 @@ const MODELS :Array = [ { path: 'fromFacebook/Ocean/zell_van_vertex_color' }, { path: 'fromFacebook/RAZ/RAZ_ape' }, { path: 'fromFbxSDK/Box' }, - { path: 'fromFbxSDK/Humanoid' }, - { path: 'fromFbxSDK/Camera' }, + { + path: 'fromFbxSDK/Humanoid', + args: [ '--no-khr-lights-punctual' ], + }, + { + path: 'fromFbxSDK/Camera', + args: [ '--no-khr-lights-punctual' ], + }, { path: 'fromFbxSDK/Normals' }, { path: 'fromGltfSamples/BoxVertexColors/BoxVertexColors' }, { path: 'fromGltfSamples/WaterBottle/NewWaterBottle' }, @@ -41,7 +48,7 @@ describe('FBX2glTF', () => { const glbPath = path.join(tmpobj.name, modelName + '.glb'); try { - const destPath = await fbx2gltf(fbxPath, glbPath); + const destPath = await fbx2gltf(fbxPath, glbPath, model.args || []); assert.isNotNull(destPath); glbBytes = readFileSync(destPath); } catch (err) {