From 075dc4a8c3b3dad137a0cd25273de2f93010ddc3 Mon Sep 17 00:00:00 2001 From: Par Winzell Date: Fri, 27 Oct 2017 15:47:49 -0700 Subject: [PATCH] Fix and improve inheritance warnings. We were warnings against eInheritRSrs, which is actually the one type of ineritance we're good with. It's eInheritRrSs we should freak out about. That said, no need to do it for the root node -- at that point there is no global transform to worry about. --- src/Fbx2Raw.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Fbx2Raw.cpp b/src/Fbx2Raw.cpp index d293c4e..c89798b 100644 --- a/src/Fbx2Raw.cpp +++ b/src/Fbx2Raw.cpp @@ -797,11 +797,11 @@ static void ReadNodeHierarchy( fmt::printf("node %d: %s\n", nodeIndex, newPath.c_str()); } - static int warnRSrsCount = 0; + static int warnRrSsCount = 0; static int warnRrsCount = 0; - if (lInheritType == FbxTransform::eInheritRSrs) { - if (++warnRSrsCount == 1) { - fmt::printf("Warning: node %s uses unsupported transform inheritance type 'eInheritRSrs'.\n", newPath); + if (lInheritType == FbxTransform::eInheritRrSs && !parentName.empty()) { + if (++warnRrSsCount == 1) { + fmt::printf("Warning: node %s uses unsupported transform inheritance type 'eInheritRrSs'.\n", newPath); fmt::printf(" (Further warnings of this type squelched.)\n"); }